Skip to content

UpdateSdkMan recipe to support newJavaVersion=latest.patch#990

Merged
timtebeek merged 4 commits intomainfrom
greg-sdkman-minor-version
Feb 19, 2026
Merged

UpdateSdkMan recipe to support newJavaVersion=latest.patch#990
timtebeek merged 4 commits intomainfrom
greg-sdkman-minor-version

Conversation

@greg-at-moderne
Copy link
Contributor

@greg-at-moderne greg-at-moderne commented Feb 19, 2026

Please review the actual proposed interface to the recipe. Is specifying sameMajor String to newJavaVersion option a decent way of handling this? My hunch is it's not, but not sure what's the better way.

What's changed?

Make UpdateSdkMan recipe support sameMajor as a possible value to newJavaVersion option.
If specified, it will update Java within the same major version, using the same distribution (unless specified otherwise).

What's your motivation?

Have a way to quickly update all the sdkmanrc files to use unified versions. And using latest version within the same major seems to make sense.

@greg-at-moderne greg-at-moderne self-assigned this Feb 19, 2026
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Feb 19, 2026
@greg-at-moderne greg-at-moderne changed the title UpdateSdkMan recipe to support newJavaVersion=minor UpdateSdkMan recipe to support newJavaVersion=sameMajor Feb 19, 2026
@greg-at-moderne greg-at-moderne marked this pull request as ready for review February 19, 2026 19:36
@timtebeek
Copy link
Member

@greg-at-moderne
Copy link
Contributor Author

Good idea. I like your suggestion.

@greg-at-moderne greg-at-moderne changed the title UpdateSdkMan recipe to support newJavaVersion=sameMajor UpdateSdkMan recipe to support newJavaVersion=latest.patch Feb 19, 2026
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Feb 19, 2026
@timtebeek timtebeek merged commit 626e34f into main Feb 19, 2026
1 check passed
@timtebeek timtebeek deleted the greg-sdkman-minor-version branch February 19, 2026 20:55
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Feb 19, 2026
mergify bot added a commit to robfrank/linklift that referenced this pull request Feb 26, 2026
…27.0 to 3.28.0 [skip ci]

[//]: # (dependabot-start)
⚠️ \*\*Dependabot is rebasing this PR\*\* ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
---
[//]: # (dependabot-end)
Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.27.0 to 3.28.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).*

> 3.28.0
> ------
>
> What's Changed
> --------------
>
> * Add maven-compiler-plugin version when missing during Java migration by [`@​jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-migrate-java#989](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/989)
> * `UpdateSdkMan` recipe to support `newJavaVersion=latest.patch` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-migrate-java#990](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/990)
> * Fix UpdateSdkManTest to use current SDKMAN Java versions by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#991](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/991)
>
> **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.27.1...v3.28.0>
>
> 3.27.1
> ------
>
> What's Changed
> --------------
>
> * Add UpgradePluginsForJava25 for surefire, failsafe, compiler, and byte-buddy by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#981](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/981)
> * Skip adding methods already provided by a superclass by [`@​Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-migrate-java#983](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/983)
> * Prevent UseTextBlocks from dropping comments in concatenations by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#985](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/985)
> * Prevent LombokValToFinalVar from removing star imports by [`@​Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-migrate-java#986](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/986)
> * Retain javax.xml.bind:jaxb-api when jackson-module-jaxb-annotations is present by [`@​Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-migrate-java#987](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/987)
>
> **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.27.0...v3.27.1>


Commits

* [`f5a2bd8`](openrewrite/rewrite-migrate-java@f5a2bd8) Update Gradle wrapper to 9.3.1
* [`0b2cb73`](openrewrite/rewrite-migrate-java@0b2cb73) Fix UpdateSdkManTest to use current SDKMAN Java versions ([#991](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/991))
* [`7c8b223`](openrewrite/rewrite-migrate-java@7c8b223) [Auto] SDKMAN! Java candidates as of 2026-02-23T1044
* [`e750f1b`](openrewrite/rewrite-migrate-java@e750f1b) OpenRewrite recipe best practices
* [`f30e774`](openrewrite/rewrite-migrate-java@f30e774) Update SDKMan Java version
* [`626e34f`](openrewrite/rewrite-migrate-java@626e34f) `UpdateSdkMan` recipe to support `newJavaVersion=latest.patch` ([#990](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/990))
* [`32b8caa`](openrewrite/rewrite-migrate-java@32b8caa) OpenRewrite recipe best practices
* [`c17f866`](openrewrite/rewrite-migrate-java@c17f866) Add maven-compiler-plugin version when missing during Java migration ([#989](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/989))
* [`56b280c`](openrewrite/rewrite-migrate-java@56b280c) Retain javax.xml.bind:jaxb-api when jackson-module-jaxb-annotations is presen...
* [`0c1793f`](openrewrite/rewrite-migrate-java@0c1793f) Prevent LombokValToFinalVar from removing star imports ([#986](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/986))
* Additional commits viewable in [compare view](openrewrite/rewrite-migrate-java@v3.27.0...v3.28.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-migrate-java&package-manager=maven&previous-version=3.27.0&new-version=3.28.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants